Update embedfs implementation #137
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjbgf
requested changes
Jul 24, 2025
There was a problem hiding this comment.
@this-kirke thanks for proposing these changes. Please take a look at the feedback below.
this-kirke
force-pushed
the
feature/update-embedfs
branch
4 times, most recently
from
0f56f9c to
6ad6516
Compare
|
Hi Paulo! Thank you for the review. I've updated with requested changes; all tests pass. |
pjbgf
requested changes
Jul 27, 2025
There was a problem hiding this comment.
@this-kirke Thanks for the follow up. I just did a full review now, there are a few tests that are redundant which we can remove. But otherwise it LGTM.
Please squash your commits once you are done with the changes below.
|
Thank you for the detailed review! I agree on all points. I think everything should be resolved now; please let me know if there's anything else you notice. We can squash on complete. |
- Add chroot functionality to embedfs using billy's chroot helper, enabling compatibility with filesystem operations that require path isolation - Fix path normalization to support billy's absolute path convention - Implement Lstat method - Additional tests to cover embedfs implementation
this-kirke
force-pushed
the
feature/update-embedfs
branch
from
5cb6e4d to
b89ce64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to embedfs implementation:
Additional test coverage:
Test infrastructure:
The embedfs implementation now provides billy.Filesystem compliance for read-only embedded filesystems.